Skip to content

Release r1.2 (Fall'25 M4)#18

Merged
chinaunicomyangfan merged 18 commits intocamaraproject:mainfrom
chinaunicomyangfan:Fall25-M4
Sep 15, 2025
Merged

Release r1.2 (Fall'25 M4)#18
chinaunicomyangfan merged 18 commits intocamaraproject:mainfrom
chinaunicomyangfan:Fall25-M4

Conversation

@chinaunicomyangfan
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Publication of Fall'25 M4 public release of subscription-status v0.1.0

@ToshiWakayama-KDDI
Copy link

Hi @chinaunicomyangfan ,

In the yaml file, ErrorInfo properties description needs to be fixed to align with the latest Commonalities, I think. L.197 description of ‘code’ and L.200 description of ‘message’. I don't have enough time now, so, please look at other APIs' Commonalities alignment PRs.

Thanks,
Toshi

@hdamker
Copy link
Contributor

hdamker commented Sep 2, 2025

Hi @chinaunicomyangfan ,

In the yaml file, ErrorInfo properties description needs to be fixed to align with the latest Commonalities, I think. L.197 description of ‘code’ and L.200 description of ‘message’. I don't have enough time now, so, please look at other APIs' Commonalities alignment PRs.

Thanks, Toshi

You can use https://github.com/camaraproject/QualityOnDemand/pull/484/files, code/API_definitions/qos-profiles.yaml as an example. And keep the order (status -> code -> message) as is even if CAMARA_common.yaml has currently another one (see camaraproject/Commonalities#515).

@chinaunicomyangfan
Copy link
Contributor Author

Thanks, @ToshiWakayama-KDDI and @hdamker .I have updated the descriptions in ErrorMode in 4bfcd3c , please review.

Copy link

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello team

Reviewed on behalf of Release Management Review team
Great PR - Just 2 small proposal.

Please consider to provide confirmation for #19 as it is mandatory for approval.

Thanks !

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chinaunicomyangfan this is not the full review by release management, I have just seen the two issues which you have introduced with the last two commits and suggest to fix them.

@hdamker hdamker requested a review from a team September 12, 2025 06:09
@hdamker hdamker dismissed their stale review September 12, 2025 08:05

Thanks, GitHub links are looking good now again.

@hdamker hdamker requested review from a team and hdamker September 12, 2025 08:05
Copy link

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello

Look good now and thanks @hdamker for the catch following latest update.
We can move forward.

Next steps for the team:
• [ ] PR merged (by API repository codeowner)
• [ ] Release created within GitHub (by API repository codeowner)
• [ ] Release Tracker updated (with creation date of the release and the release tag link)

Copy link

@ChuanyuChen ChuanyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@chinaunicomyangfan chinaunicomyangfan merged commit 19aed34 into camaraproject:main Sep 15, 2025
2 checks passed
@chinaunicomyangfan
Copy link
Contributor Author

@bigludo7 Thanks for the review.I have create a new public release r1.2 ,and the tracker has been updated.
Please check,thanks

@bigludo7
Copy link

Checked and everything is fine
Thanks a lot @chinaunicomyangfan for your contribution !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants