Skip to content

Update error schema for compliance with upcoming Commonalities r3.4#62

Draft
eric-murray wants to merge 4 commits intocamaraproject:mainfrom
eric-murray:eric-murray-patch-1
Draft

Update error schema for compliance with upcoming Commonalities r3.4#62
eric-murray wants to merge 4 commits intocamaraproject:mainfrom
eric-murray:eric-murray-patch-1

Conversation

@eric-murray
Copy link
Contributor

@eric-murray eric-murray commented Aug 26, 2025

What type of PR is this?

  • correction

What this PR does / why we need it:

This PR updates the error schema for compliance with Commonalities r3.4

Which issue(s) this PR fixes:

Fixes #N/A

Special notes for reviewers:

None

Changelog input

 release-note
 - Update error schema for compliance with Commonalities r3.4

Additional documentation

None

alpaycetin74
alpaycetin74 previously approved these changes Aug 26, 2025
Copy link
Contributor

@alpaycetin74 alpaycetin74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

Copy link
Contributor

@stroncoso-quobis stroncoso-quobis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order status -> code -> message is compliant with the API Design Guide, there is no need to change it, see camaraproject/Commonalities#515.

Beyond that the change does not make sense as long as the examples are not changed as well.

@eric-murray eric-murray changed the title Update error schema for compliance with Commonalities r3.3 Update error schema for compliance with upcoming Commonalities r3.4 Sep 2, 2025
@eric-murray
Copy link
Contributor Author

Updated for compliance with upcoming Commonalities r3.4 schema. I will set this to draft until Commonalities r3.4 is published.

@eric-murray eric-murray marked this pull request as draft September 2, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants