Adding UML diagrams in API provider perspective Part2#139
Open
teikuran wants to merge 8 commits intocamaraproject:mainfrom
Open
Adding UML diagrams in API provider perspective Part2#139teikuran wants to merge 8 commits intocamaraproject:mainfrom
teikuran wants to merge 8 commits intocamaraproject:mainfrom
Conversation
Updated the README to include additional call flow examples and corrected links.
adding registration and call origination_and_disconnection flow
Contributor
|
Hi @teikuran Thanks very much for the documentation work, it really shapes the API and it brings our eyes over the real implementations problems. I noticed that you include several "ISSUE (NotAddressed)" comments on the doc, do not hesitate to create them on the repo, in order to properly address them one-by-one. Some initial comments:
We can comment it and agreed on results to merge and next steps at today's meeting. Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Following Adding UML diagrams in API provider perspective #122, new flow examples are proposed to be added.
Changelog input