[IMP] otools-migrate-db: increase perf on some DB restore #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And rename `mount_opts` here and there to `run_opts` to store any kind of options that could be useful by `docker compose run`.
sebalix
commented
Oct 2, 2025
| run_opts = ( | ||
| f"-v {ctx.obj['store_path']}:/{ctx.obj['container_store_path']} " | ||
| # Increase PostgreSQL performance on restore | ||
| f"-e PGOPTIONS='-c full_page_writes=off -c autovacuum=off'" |
Contributor
Author
There was a problem hiding this comment.
It's useless to put these options here, both full_page_writes and autovacuum have to be set in the postgresql.conf file or on Pg command line. They are not supposed to work at user session level.Closing this PR.
Better to enable them by default in docker-compose.yml:
db:
image: ghcr.io/camptocamp/postgres:14-postgis-3
command: >-
[...]
-c autovacuum=off
# Speed up DB restore (could corrupt DB in case of failing system)
# but it's a good deal for dev purpose.
-c full_page_writes=off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And rename
mount_optshere and there torun_optsto store any kind of options that could be useful bydocker compose run.