fix(bpmn): resolve all bpmnlint errors in quick-start and solutions#97
Open
HanselIdes wants to merge 2 commits intomainfrom
Open
fix(bpmn): resolve all bpmnlint errors in quick-start and solutions#97HanselIdes wants to merge 2 commits intomainfrom
HanselIdes wants to merge 2 commits intomainfrom
Conversation
Fixes 21 errors across 9 BPMN files: - no-bpmndi: add missing BPMNShape/BPMNEdge diagram entries for TextAnnotation and Association intro elements in Azure AI, HuggingFace, CI-CD, Error Handling, Event Registration, Expense Reimbursement, Ticket Booking, RPA Orchestration, and AI Email Support Agent - label-required: add names to unnamed boundary/start/end events in CI-CD (fileNotFoundBoundaryEvent), Error Handling (subprocess start/end), and RPA Orchestration (compensation boundary event) - no-gateway-join-fork: split Gateway_1j8nunf in RPA Orchestration into a joining ExclusiveGateway upstream of the EventBasedGateway fork - Remove unused Error_11kp03o from Ticket Booking and Message_0fr5ip9 from AI Email Support Agent Also adds a PostToolUse hook to .claude/settings.local.json that runs bpmnlint automatically after any .bpmn file is written or edited. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ions - Add lint script to package.json excluding test/target build artifacts - Add missing BPMNShape/BPMNEdge for TextAnnotation elements in quick-start API orchestration, microservice orchestration, and human-task tutorials - Add zeebe:FormDefinition to prepare-chicken and prepare-salad user tasks; add corresponding form files - Add zeebe:FormDefinition to task-listeners Auto_assigned user task - Add missing zeebe:UserTask extension to 5 user tasks in HuggingFace routing - Fix bank-ai-loan-approval: merge duplicate escalation/error definitions, insert joining gateway for fake-join on Event_1wd6fel, convert implicit-end intermediateThrowEvent to endEvent, expand subprocess bounds - Fix rpa-orchestration overlap by moving Event_1fr1ftj clear of gateway - Fix ai-agent-chat-with-mcp: insert joining gateway for Filesystem fake-join, expand AI_Agent subprocess to contain Event_Sub_Process - Remove unused signals from capital-market and telco solutions One warning intentionally remains: Event_1hlbn3w in car-rental is a compensation boundary event with no outgoing sequence flow by design. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
HanselIdes
force-pushed
the
fix/bpmnlint-quick-start-solutions
branch
from
ab1ef4f to
692a1ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quick-start/andsolutions/BPMN fileslintnpm script topackage.jsonthat excludestest/targetbuild artifacts from scanningEvent_1hlbn3wincar-rental-booking-processis a compensation boundary event — it has no outgoing sequence flow by design, making theno-implicit-endreport a false positiveChanges by category
no-bpmndi(missing diagram elements)Added
BPMNShapeandBPMNEdgeforTextAnnotation+Associationelements in:quick-start/api-orchestrationquick-start/microservice-orchestrationquick-start/human-task-orchestrationzeebe:FormDefinitionmissingquick-start/human-task-orchestration: addedzeebe:formDefinitiontoprepare-chickenandprepare-saladuser tasks; added corresponding.formfilesquick-start/task-listeners: addedzeebe:formDefinitionto the auto-assigned user taskzeebe:UserTaskmissingsolutions/ai-intelligent-routing: added<zeebe:userTask />to all 5 user tasks (required for Camunda 8.8)fake-join(multiple flows into a non-gateway element)solutions/bank-ai-loan-approval: inserted joiningExclusiveGatewaybeforeEvent_1wd6fel; expanded subprocess boundssolutions/ai-agent-chat-with-mcp: inserted joiningExclusiveGatewaybeforeFilesystemservice task; expandedAI_Agentsubprocess to containEvent_Sub_Processglobal(duplicate element names / unused elements)solutions/bank-ai-loan-approval: merged 3 duplicate escalation definitions and 2 duplicate error definitions down to one each; removed unused duplicate definitionssolutions/capital-market-exception-processing: removed unused signalSignal_3smleomsolutions/telco-service-order-fulfillment-retail: removed unused signalSignal_0m4udetno-implicit-endsolutions/bank-ai-loan-approval: convertedEvent_1jfz6dkfromintermediateThrowEventtoendEventno-overlapping-elementssolutions/rpa-orchestration-uipath: movedEvent_1fr1ftj27px left to clear overlap withGateway_join_before_ebgTest plan
npm run lintpasses with 0 errors and 1 justified warning (car-rental compensation boundary)🤖 Generated with Claude Code