-
Notifications
You must be signed in to change notification settings - Fork 145
feat: Add OpenSearch Dependency to 8.9 Helm #4873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Only adding the dependency as we need to use it in our load tests, this is not a WIP for adding support for this and not planning to merge this. There is a distribution dependency in https://github.com/camunda/product-hub/issues/3053 (this ticket) to officially add OpenSearch to Helm, and once thats available we will use that |
b3c29d4 to
6ff6622
Compare
Adding OpenSearch chart as a dependency to the 8.9 camunda platform helm. This is only used if `opensearch.enabled` and by default its set to `false`. Also add default configuration to values.yaml with image repository location (bitnamilegacy) and version used along with memory settings.
6ff6622 to
b4eec36
Compare
|
@jessesimpson36 I just thought I'll share my findings in adding the OpenSearch container to Helm. I think you are assigned the ticket in DB Initiative epic to add this. I had to do this change to be able to run a load test using OpenSearch.. And ofc, once your work is in we can close this and use the official support 👍 |
|
@yohanfernando , thanks for the PR, but I think this is moving in the opposite direction of where we want to be. In the long term, we're hoping to get away from provisioning elasticsearch (and opensearch) within the Helm charts, and rely on generic options to connect to elasticsearch or opensearch hosted elsewhere. This is partly because bitnami has been moving around their repos, deleting old entries, and being frankly very confusing with their premium plan support, and the other part of this is when we have an option in the helm chart, people tend to favor that over more reliable solutions, like having a cloud hosted elasticsearch or opensearch option. it'd be making it easy to do the wrong thing, and easy for customers to come to us with all their elasticsearch and opensearch related support tickets that have nothing to do with the Camunda components. Is there a way for you to provision opensearch inside your CI or rely on a cloud-hosted opensearch instance for your test? |
@jessesimpson36 since the PR, I learnt about that from a several including @ChrisKujawa. What I thought was we were going to still have that as an "example", but heard it's not the case. I'm sure we can find a way to do this within the load-test, I will chat to Chris. I will leave this open in the short term and once move to a long-term supported structure will close this. Thanks |
Which problem does the PR fix?
We need to have OpenSearch added as a dependency to Helm to be able to run load tests with OpenSearch containers.
What's in this PR?
Adding OpenSearch chart as a dependency to the 8.9 Camunda Platform Helm. This is only used if
opensearch.enabledand by default its set tofalse.Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: