-
Notifications
You must be signed in to change notification settings - Fork 145
ci: update cli to support eks #4908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
356f258 to
531e1f3
Compare
1c03de8 to
776722b
Compare
|
rebased after installing the upgraded version of ExternalSecrets Operator. |
|
@eamonnmoloney I needed to apply this so that I could upgrade the ExternalSecrets operator. Could you approve+merge the linked infra PR please ? |
jessesimpson36
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the code and updated external secrets operator. I didn't run this myself since the changes were pretty minimal. just minor updates to the script and re-organization to make the 2 platforms more uniform. If you're planning any other bigger changes, let me know before merge.
…netes Added a new function to format user-friendly error messages for namespace permission errors. Updated existing methods to utilize this function when encountering forbidden errors, improving clarity for users regarding permission issues in Kubernetes operations.
Added a function to identify usage errors and enhance error reporting in the deploy-camunda command. Now, usage errors will display help information, while runtime errors will be printed without usage details, improving user experience during command execution.
Introduced a new configuration file for the Prometheus service monitor, setting the enabled flag to false. Enhanced error handling in the kube package to improve namespace permission error messages and updated the deploy-camunda script to include a namespace prefix for deployments.
…nce platform-specific file processing Removed Prometheus service monitor configurations from various integration test YAML files, consolidating them into a new service-monitor.yaml file. Enhanced the processCommonValues function to support platform-specific configurations, improving the handling of common values files during deployment.
…iles Changed the apiVersion from v1beta1 to v1 in various ExternalSecret configuration files to align with the latest API standards. This includes updates in both the GitHub configuration and the Camunda platform integration test credentials.
Updated the Makefile to include 'go mod tidy' in build and install commands for various scripts, ensuring dependencies are properly managed. Introduced a new ExternalSecret configuration file for vault integration and updated the API version in existing YAML files. Additionally, modified the kube package and related scripts to support an external secrets store parameter, improving flexibility in secret management across different platforms.
9765d70 to
9f51d47
Compare
Which problem does the PR fix?
What's in this PR?
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: