fix: build correct alt dna sequence for deletions#647
fix: build correct alt dna sequence for deletions#647katie-perry wants to merge 7 commits intostagingfrom
Conversation
jarbesfeld
left a comment
jarbesfeld
left a comment
There was a problem hiding this comment.
@katie-perry Nice work! This looks good to me
| aa_start_pos += aa_match | ||
| aa_alt = aa_alt[aa_match:] if trim_prefix else aa_alt[:-aa_match] | ||
| aa_ref = aa_ref[aa_match:] if trim_prefix else aa_ref[:-aa_ref] | ||
| aa_ref = aa_ref[aa_match:] if trim_prefix else aa_ref[:-aa_match] |
There was a problem hiding this comment.
@korikuzma just wanted your eyes to double check on this - is this correct? It seemed like a bug so I changed it but it wasn't impacting any tests... maybe I should write some tests for this if there aren't already some
|
@katie-perry Could you add two additional checks in the |
great idea - I will work on this! |
2 participants
#447