Skip to content

Fix header link to point to root docs page#10

Merged
rkratky merged 1 commit intocanonical:mainfrom
rkratky:header-link
Jan 27, 2026
Merged

Fix header link to point to root docs page#10
rkratky merged 1 commit intocanonical:mainfrom
rkratky:header-link

Conversation

@rkratky
Copy link
Copy Markdown
Contributor

@rkratky rkratky commented Jan 22, 2026

$subj

@rkratky rkratky requested a review from YanisaHS January 22, 2026 14:07
@rkratky rkratky added bug Something isn't working documentation Improvements or additions to documentation labels Jan 22, 2026
@YanisaHS
Copy link
Copy Markdown
Collaborator

@rkratky This is supposed to change where this link goes, right?

image

It 404s when I tested it from the RTD build check - is that expected because it's a temporary link..? Or does it need to be /airgapped? (I'm not sure)

@rkratky
Copy link
Copy Markdown
Contributor Author

rkratky commented Jan 26, 2026

This is supposed to change where this link goes, right?

Yes.

It 404s when I tested it from the RTD build check - is that expected because it's a temporary link..?

Oh, must've missed something. Not expected. Thanks for catching that. Let me retest.

@rkratky
Copy link
Copy Markdown
Contributor Author

rkratky commented Jan 26, 2026

Ah, ok. I'm not 200% sure, but I think you're right. It's only 404ing because it's the test build for the canonical-ubuntu-documentation-library project, i.e. for documentation.ubuntu.com, so it uses the slug.

Now, I'd think that pointing to the root would point to the base of a particular docs set, but here it pbbly points to documentation.ubuntu.com/, so adding the slug is needed (which then makes impossible to test on local...).

Trying it...

@rkratky
Copy link
Copy Markdown
Contributor Author

rkratky commented Jan 26, 2026

Yup, it now works in the PR, so I hope it'll be the same in prod, too 😇

Copy link
Copy Markdown
Collaborator

@YanisaHS YanisaHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll see!! ⭐

@rkratky rkratky merged commit d7d11aa into canonical:main Jan 27, 2026
3 of 5 checks passed
@rkratky rkratky deleted the header-link branch January 27, 2026 13:33
@rkratky
Copy link
Copy Markdown
Contributor Author

rkratky commented Jan 27, 2026

It worked :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants