Skip to content

test: import apport-retrace to get coverage data#544

Open
bdrung wants to merge 1 commit intocanonical:mainfrom
bdrung:retrace-coverage
Open

test: import apport-retrace to get coverage data#544
bdrung wants to merge 1 commit intocanonical:mainfrom
bdrung:retrace-coverage

Conversation

@bdrung
Copy link
Copy Markdown
Member

@bdrung bdrung commented Jun 20, 2025

Calling apport-retrace as separate binary will prevent collecting code coverage data. So import the apport-retrace file and call the main function there.

@bdrung bdrung added the test label Jun 20, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 20, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.44%. Comparing base (5129c9d) to head (6f9cba5).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
tests/system/test_apport_retrace.py 88.88% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
- Coverage   84.47%   84.44%   -0.03%     
==========================================
  Files         104      104              
  Lines       20938    20950      +12     
  Branches     3212     3215       +3     
==========================================
+ Hits        17687    17691       +4     
- Misses       2813     2817       +4     
- Partials      438      442       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@laarmen laarmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably more importantly, it makes it much easier to debug when a test fails!

LGTM, assuming the tests end up passing? I don't have access to the test logs anymore.

@bdrung bdrung force-pushed the retrace-coverage branch from 6881b64 to ea87cdd Compare April 1, 2026 10:16
@bdrung
Copy link
Copy Markdown
Member Author

bdrung commented Apr 1, 2026

Rebased and reworked a bit. Let's see what the CI says.

@bdrung bdrung force-pushed the retrace-coverage branch from ea87cdd to be50c21 Compare April 8, 2026 12:43
Calling `apport-retrace` as separate binary will prevent collecting code
coverage data. So import the apport-retrace file and call the `main`
function there.
@bdrung bdrung force-pushed the retrace-coverage branch from be50c21 to 6f9cba5 Compare April 8, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants