Skip to content

crashdb/launchpad: support CoreDump.zst#576

Merged
bdrung merged 1 commit intocanonical:mainfrom
bdrung:retrace-zstd
Apr 24, 2026
Merged

crashdb/launchpad: support CoreDump.zst#576
bdrung merged 1 commit intocanonical:mainfrom
bdrung:retrace-zstd

Conversation

@bdrung
Copy link
Copy Markdown
Member

@bdrung bdrung commented Apr 20, 2026

When Apport is used with systemd-coredump, the CoreDump is zstd compressed (instead of gzip).

Support retracing a core dump that is zstd compressed (and named CoreDump.zst).

Tested with:

divide-by-zero
PYTHONPATH=$(pwd) APPORT_LAUNCHPAD_INSTANCE=qastaging bin/apport-cli /var/crash/_usr_bin_divide-by-zero.1000.crash
PYTHONPATH=$(pwd) APPORT_LAUNCHPAD_INSTANCE=qastaging bin/apport-retrace --auth ~/.cache/apport/launchpad.credentials -S system 2143169

This PR is stacked on top of #575

LP: #2148656

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.51%. Comparing base (a36ff96) to head (16d520b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apport/crashdb_impl/launchpad.py 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
- Coverage   84.52%   84.51%   -0.01%     
==========================================
  Files         104      104              
  Lines       20984    20987       +3     
  Branches     3217     3218       +1     
==========================================
+ Hits        17737    17738       +1     
- Misses       2806     2808       +2     
  Partials      441      441              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@Hyask Hyask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once I figured only the last commit was actually up for review after looking at #575, that went quick. I guess I'm really running in low power mode today 😅

When Apport is used with systemd-coredump, the CoreDump is zstd
compressed (instead of gzip).

Support retracing a core dump that is zstd compressed (and named
`CoreDump.zst`).

Tested with:

```
divide-by-zero
PYTHONPATH=$(pwd) APPORT_LAUNCHPAD_INSTANCE=qastaging bin/apport-cli /var/crash/_usr_bin_divide-by-zero.1000.crash
PYTHONPATH=$(pwd) APPORT_LAUNCHPAD_INSTANCE=qastaging bin/apport-retrace --auth ~/.cache/apport/launchpad.credentials -S system 2143169
```

Bug: https://launchpad.net/bugs/2148656
@bdrung
Copy link
Copy Markdown
Member Author

bdrung commented Apr 24, 2026

Just rebased and re-tested.

@bdrung bdrung merged commit 16d520b into canonical:main Apr 24, 2026
17 of 19 checks passed
@bdrung bdrung deleted the retrace-zstd branch April 24, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants