Skip to content

Retrace proxy fix#577

Merged
bdrung merged 3 commits intocanonical:mainfrom
seb128:retrace-proxy-fix
Apr 24, 2026
Merged

Retrace proxy fix#577
bdrung merged 3 commits intocanonical:mainfrom
seb128:retrace-proxy-fix

Conversation

@seb128
Copy link
Copy Markdown
Contributor

@seb128 seb128 commented Apr 20, 2026

No description provided.

@seb128
Copy link
Copy Markdown
Contributor Author

seb128 commented Apr 20, 2026

Launchpad bug https://bugs.launchpad.net/apport/+bug/2148926

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.47%. Comparing base (c1fba5d) to head (b434538).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
apport/packaging_impl/apt_dpkg.py 33.33% 3 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   84.46%   84.47%   +0.01%     
==========================================
  Files         104      104              
  Lines       20936    20926      -10     
  Branches     3212     3212              
==========================================
- Hits        17683    17677       -6     
+ Misses       2814     2808       -6     
- Partials      439      441       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdrung
Copy link
Copy Markdown
Member

bdrung commented Apr 20, 2026

The linter is complaining. You can rebase your changes on top of #578 to avoid running into _fetch_contents_file is too complex.

bdrung
bdrung reviewed Apr 20, 2026
View reviewed changes
Comment thread apport/packaging_impl/apt_dpkg.py
@seb128
Copy link
Copy Markdown
Contributor Author

seb128 commented Apr 21, 2026

Thanks, I will rebase once #578 lands

@bdrung
Copy link
Copy Markdown
Member

bdrung commented Apr 22, 2026

I rebased your changs on top of #578, added LP reference, adjusted the title, and pushed to https://github.com/bdrung/apport/commits/retrace-proxy-fix/

seb128 added 3 commits April 24, 2026 14:41
@seb128
apt_dpkg: use urllib.request instead of http.client to get contents
189aa90 
the urllib API works with standard proxy environments

Bug: https://launchpad.net/bugs/2116119
@seb128
apt_dpkg: don't disable proxy use to download deb files
db62bd2 
The use of direct mode was initially added in #85a9737 it seems to
workaround infrastructure issues, it worked on PS5 which had direct access
to the archive but not on PS7 which have a mandatory proxy.

Bug: https://launchpad.net/bugs/2116119
@seb128
apt_dpkg: don't clear the proxy when fetching sources
b434538 
Bug: https://launchpad.net/bugs/2116119
@seb128 seb128 force-pushed the retrace-proxy-fix branch from 5ab56b6 to b434538 Compare April 24, 2026 12:52
bdrung
bdrung approved these changes Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@bdrung bdrung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and was already tested successfully.

@bdrung bdrung merged commit b434538 into canonical:main Apr 24, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdrung bdrung bdrung approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seb128 @bdrung