sandboxutils: use return early pattern in make_sandbox()#582
Open
bdrung wants to merge 1 commit intocanonical:mainfrom
Open
sandboxutils: use return early pattern in make_sandbox()#582bdrung wants to merge 1 commit intocanonical:mainfrom
bdrung wants to merge 1 commit intocanonical:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
==========================================
+ Coverage 84.45% 84.46% +0.01%
==========================================
Files 104 104
Lines 20939 20944 +5
Branches 3212 3212
==========================================
+ Hits 17683 17690 +7
+ Misses 2816 2814 -2
Partials 440 440 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bdrung
force-pushed
the
continue-early
branch
2 times, most recently
from
0e15958 to
ce6f918
Compare
Use the return early pattern in `make_sandbox` to make the code more readable and to ease adding type hints to `ProblemReport` later. This change avoids duplicating the code for the failure case. Do not reuse the iterator key to allow mypy to correctly derive the type of the `report.get()` call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the return early pattern in
make_sandboxto make the code more readable and to ease adding type hints toProblemReportlater. This change avoids duplicating the code for the failure case.