ui: deduplicate code in get_complete_size/get_reduced_size#583
Open
bdrung wants to merge 1 commit intocanonical:mainfrom
Open
ui: deduplicate code in get_complete_size/get_reduced_size#583bdrung wants to merge 1 commit intocanonical:mainfrom
bdrung wants to merge 1 commit intocanonical:mainfrom
Conversation
The code in `UserInterface.get_complete_size()` and `UserInterface.get_reduced_size()` is quite similar. Introduce a helper method `UserInterface._get_size()` to avoid this duplicate code.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
==========================================
- Coverage 84.45% 84.44% -0.01%
==========================================
Files 104 104
Lines 20939 20935 -4
Branches 3212 3211 -1
==========================================
- Hits 17683 17679 -4
Misses 2816 2816
Partials 440 440 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code in
UserInterface.get_complete_size()andUserInterface.get_reduced_size()is quite similar.Introduce a helper method
UserInterface._get_size()to avoid this duplicate code.