test: avoid strip() on problem report Order key#584
Open
bdrung wants to merge 1 commit intocanonical:mainfrom
Open
test: avoid strip() on problem report Order key#584bdrung wants to merge 1 commit intocanonical:mainfrom
bdrung wants to merge 1 commit intocanonical:mainfrom
Conversation
The value for the `Order` key is of type `ProblemReportValue` which might not have the `strip()` method. So avoid calling `strip()` to make the test more robust and allow adding more type hints to `ProblemReport`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
=======================================
Coverage 84.45% 84.45%
=======================================
Files 104 104
Lines 20939 20939
Branches 3212 3212
=======================================
Hits 17683 17683
Misses 2816 2816
Partials 440 440 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value for the
Orderkey is of typeProblemReportValuewhich might not have thestrip()method.So avoid calling
strip()to make the test more robust and allow adding more type hints toProblemReport.