Add authctl user set-shell command

[adombeck]

Important

This is based on #1087, please review and merge that first.

Allow users to change their shell.

Closes #939
UDENG-7089

[codecov-commenter]

Codecov Report

❌ Patch coverage is 63.65462% with 181 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.08%. Comparing base (6ff09d2) to head (dfb2353).

Files with missing lines	Patch %	Lines
internal/users/proc/proc.go	60.41%	38 Missing ⚠️
cmd/authctl/internal/completion/completion.go	0.00%	29 Missing ⚠️
internal/users/db/update.go	70.96%	27 Missing ⚠️
cmd/authctl/user/set-uid.go	0.00%	19 Missing ⚠️
cmd/authctl/group/set-gid.go	0.00%	16 Missing ⚠️
cmd/authctl/user/set-shell.go	0.00%	14 Missing ⚠️
internal/services/user/user.go	70.58%	10 Missing ⚠️
internal/services/permissions/permissions.go	66.66%	7 Missing ⚠️
internal/testlog/testlog.go	61.11%	7 Missing ⚠️
internal/users/manager.go	95.00%	6 Missing ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1165      +/-   ##
==========================================
- Coverage   87.64%   86.08%   -1.56%     
==========================================
  Files          90       97       +7     
  Lines        6222     6682     +460     
  Branches      111      111              
==========================================
+ Hits         5453     5752     +299     
- Misses        713      874     +161     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[3v1n0]

Shouldn't we also check if the shell is allowed in /etc/shells?

[adombeck]

I would prefer to follow systemd-homed in this regard:

https://github.com/systemd/systemd/blob/ba67af7efb7b743ba1974ef9ceb53fba0e3f9e21/src/basic/user-util.c#L910-L911

systemd-homed does a few other checks though, which I'll also implement:

• https://github.com/systemd/systemd/blob/ba67af7efb7b743ba1974ef9ceb53fba0e3f9e21/src/home/homectl.c#L2822-L2830
• https://github.com/systemd/systemd/blob/ba67af7efb7b743ba1974ef9ceb53fba0e3f9e21/src/basic/user-util.c#L882-L902

[adombeck]

systemd-homed does a few other checks though, which I'll also implement:

done

[codecov]

Codecov Report

❌ Patch coverage is 70.00000% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.49%. Comparing base (1b9ea6b) to head (455feb4).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/authctl/user/set-shell.go	0.00%	14 Missing ⚠️
internal/services/permissions/permissions.go	66.66%	7 Missing ⚠️
internal/services/user/user.go	66.66%	4 Missing ⚠️
internal/users/db/update.go	80.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1165      +/-   ##
==========================================
+ Coverage   85.00%   85.49%   +0.49%     
==========================================
  Files         119      101      -18     
  Lines        7669     6770     -899     
  Branches      111      111              
==========================================
- Hits         6519     5788     -731     
+ Misses       1094      926     -168     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.