WIP: Support showing a message returned by GetAuthenticationModes#1181
WIP: Support showing a message returned by GetAuthenticationModes#1181
Conversation
TODO: GDM doesn't show it
|
@3v1n0 this is the WIP branch to show a message when device authentication is required because the device registration setting was changed. On the command-line it looks like this: 
Do you think it's feasible to also show the message in GDM in the near future (i.e. in time for the upcoming authd release)? |
Oh, I can try... I think it would come in the form of a notification pop-up, given that we already have the QR code showing otherwise. |
| var msgPtr *string | ||
| if msg != "" { | ||
| msgPtr = &msg | ||
| } |
There was a problem hiding this comment.
Maybe it's time to move ptrValue outside the _test.go code?
|
|
||
| view := viewBuilder.String() | ||
|
|
||
| if m.currentSession != nil && m.currentSession.getAuthenticationModesMessage != "" { |
There was a problem hiding this comment.
Do not forget the native model (for ssh and friends) too :)
There was a problem hiding this comment.
Right. The GDM part is much more important though, without it it doesn't make sense to merge this IMO. If you get the GDM part done, I can implement the missing parts for the native model.
2 participants
TODO: GDM doesn't show it
Corresponding broker PR: ubuntu/authd-oidc-brokers#825
UDENG-8534