Skip to content

add prometheus alerts file for built-in alerting module#87

Merged
sabaini merged 1 commit intocanonical:mainfrom
slapcat:main
Dec 12, 2025
Merged

add prometheus alerts file for built-in alerting module#87
sabaini merged 1 commit intocanonical:mainfrom
slapcat:main

Conversation

@slapcat
Copy link
Copy Markdown
Contributor

@slapcat slapcat commented Dec 3, 2025

Fixes #86.

This fix will need to be backported to Quincy. Please let me know if anything else is needed to have this included in the Quincy images.

@slapcat
Copy link
Copy Markdown
Contributor Author

slapcat commented Dec 9, 2025

@UtkarshBhatthere Can I please have a review?

Copy link
Copy Markdown
Collaborator

@sabaini sabaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @slapcat

Signed-off-by: Jake Nabasny <jake.nabasny@canonical.com>
@slapcat
Copy link
Copy Markdown
Contributor Author

slapcat commented Dec 12, 2025

Thanks @sabaini ! I fixed the unverified commit, so it should be good to go.

Will this change automatically be included in the Quincy image?

@sabaini sabaini merged commit 7b166c2 into canonical:main Dec 12, 2025
3 checks passed
@sabaini
Copy link
Copy Markdown
Collaborator

sabaini commented Dec 12, 2025

Thanks @sabaini ! I fixed the unverified commit, so it should be good to go.

Will this change automatically be included in the Quincy image?

We'd need to backport this change explicitly. Would you be able to submit a PR against stable/quincy?

@slapcat
Copy link
Copy Markdown
Contributor Author

slapcat commented Dec 12, 2025

Yes, I'll submit that today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default prometheus alerts missing from image

2 participants