Skip to content
This repository was archived by the owner on Nov 26, 2025. It is now read-only.

Add karapace_client interface#282

Merged
james-garner-canonical merged 6 commits intocanonical:mainfrom
zmraul:add-karapace-interface
Nov 26, 2025
Merged

Add karapace_client interface#282
james-garner-canonical merged 6 commits intocanonical:mainfrom
zmraul:add-karapace-interface

Conversation

@zmraul
Copy link
Copy Markdown
Contributor

@zmraul zmraul commented Jul 21, 2025

Adds Karapace client interface specification.

TODO:

  • Update custom role creation

@sinclert-canonical
Copy link
Copy Markdown
Contributor

👋🏻 Hey! Same as the comment I left in the PR adding the Karapace classes to Data Interfaces v0, as well as its follow-up PR by Marc, these docs lack the addition of the custom role creation / permissions change functionality. Please, take a look at the PR expanding the other Data Platform product interfaces usage and follow the same approach.

@james-garner-canonical
Copy link
Copy Markdown
Contributor

Hi @zmraul @sinclert-canonical, we're moving towards archiving this repo very soon, however interface specifications live on in the charmlibs repo.

I'm happy to merge this PR and migrate the interface definition to charmlibs. I'm assuming the interface reflects the behaviour of the actual providers and requirers in the wild. However, @sinclert-canonical had a request for documenting custom role creation / permissions change functionality, which would be great to get done first if it's still relevant.

@zmraul zmraul force-pushed the add-karapace-interface branch from 34196db to dcda77c Compare November 24, 2025 09:43
@zmraul
Copy link
Copy Markdown
Contributor Author

zmraul commented Nov 24, 2025

@james-garner-canonical @sinclert-canonical Updated the schemas with role & permissions changes.

@james-garner-canonical
Copy link
Copy Markdown
Contributor

Thanks @zmraul, the changes look good to me. @sinclert-canonical?

I also just noticed that there isn't an interface.yaml for this interface. Could you please add one with at least:

name: karapace_client
version: 0
status: <published if charms are already using this, otherwise draft?>
maintainer: <github team name>
providers:  # any current providers, or [] otherwise
    - name: <charm name>
      url: <git repo>
requirers:  # any current requirers, or [] otherwise
    - name: <charm name>
      url: <git repo>

@zmraul
Copy link
Copy Markdown
Contributor Author

zmraul commented Nov 25, 2025

@james-garner-canonical there is one, see here

@zmraul zmraul force-pushed the add-karapace-interface branch 2 times, most recently from 1549398 to 53d2a98 Compare November 25, 2025 08:09
Copy link
Copy Markdown
Contributor

@james-garner-canonical james-garner-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this with sign off from someone else on the team -- @sinclert-canonical?

PS: Is this now just documenting an interface that is already in use in production?

Comment thread interfaces/karapace_client/v0/schema.py Outdated
@sinclert-canonical
Copy link
Copy Markdown
Contributor

Thanks @zmraul, the changes look good to me. @sinclert-canonical?

Good to me too. Thanks @zmraul!

@zmraul zmraul force-pushed the add-karapace-interface branch from ae8e0f4 to 9973c22 Compare November 26, 2025 08:30
@zmraul
Copy link
Copy Markdown
Contributor Author

zmraul commented Nov 26, 2025

PS: Is this now just documenting an interface that is already in use in production?

@james-garner-canonical this interface is in the Karapace charm, but it is not on stable track yet.

@james-garner-canonical
Copy link
Copy Markdown
Contributor

I've signed the commits for merge.

@james-garner-canonical james-garner-canonical merged commit 4cf84d1 into canonical:main Nov 26, 2025
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants