tests: add reproducer for reactive plugin missing .build.manifest (#872)#2664
Draft
tests: add reproducer for reactive plugin missing .build.manifest (#872)#2664
Conversation
Add a failing test that demonstrates the reactive charm plugin does not copy the .build.manifest file generated by 'charm build' into the install directory. This file contains valuable build metadata (layer commit hashes, pip packages from wheelhouse). Closes #872 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Type checking with Command output |
Collaborator
Author
…lugin Agent-Logs-Url: https://github.com/canonical/charmcraft/sessions/a8b41266-c7ad-42ac-977e-86c8f1078554 Co-authored-by: lengau <4305943+lengau@users.noreply.github.com>
Contributor
Fixed in commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a failing unit test that reproduces #872: when building a reactive charm, the
.build.manifestfile generated bycharm buildis not copied into the install directory.Bug
When
charm buildruns, it places.build.manifestin thebuild_dir/root alongside the charm subdirectory. The reactive plugin only symlinksbuild_dir/<charm_name>/intoinstall_dir/, so.build.manifestis never included in the.charmartifact.Reproducer
The test fails with:
Closes #872