tests: add reproducer for fetch-lib unhelpful error message (#2204)#2666
Draft
tests: add reproducer for fetch-lib unhelpful error message (#2204)#2666
Conversation
Add a failing test that demonstrates that 'charmcraft fetch-lib' produces the unhelpful error 'Library None not found in Charmhub.' when a library's lib_id is not registered in Charmhub (e.g. a local or unpublished library). The error message uses parsed_args.library (None when running without arguments) rather than including the actual library name or identifier. Closes #2204 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Type checking with Command output |
Collaborator
Author
…ovided Agent-Logs-Url: https://github.com/canonical/charmcraft/sessions/44f093c4-5a19-43d9-81e4-a1c0f64b934f Co-authored-by: lengau <4305943+lengau@users.noreply.github.com>
Contributor
Fixed in commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a failing unit test that reproduces #2204:
charmcraft fetch-libprints the unhelpful messageLibrary None not found in Charmhub.when a library'slib_idis not registered in Charmhub.Bug
When fetching all libs (no argument),
parsed_args.libraryisNone. When the Charmhub bulk API returns no entry for a local/unpublished library'slib_id, the error usesparsed_args.librarydirectly, producing"Library None not found in Charmhub."instead of a meaningful identifier.Reproducer
The test fails with:
Closes #2204