tests: add reproducer for remote-build ProjectService AttributeError (#2598)#2667
Draft
tests: add reproducer for remote-build ProjectService AttributeError (#2598)#2667
Conversation
Add a failing test that demonstrates that 'charmcraft remote-build' crashes with AttributeError: 'ProjectService' object has no attribute 'name' because remote.py casts self._services.project (a ProjectService instance) to the project model without actually calling .get(). Closes #2598 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Type checking with Command output |
Collaborator
Author
In remote.py and lifecycle.py, self._services.project returns a ProjectService instance, not the project model. Calling .get() on it returns the actual project model, fixing the AttributeError: 'ProjectService' object has no attribute 'name'. Fixes #2598 Agent-Logs-Url: https://github.com/canonical/charmcraft/sessions/02f81e14-164e-4cac-8c83-0d086d128d21 Co-authored-by: lengau <4305943+lengau@users.noreply.github.com>
Contributor
Fixed in commit 5904d87. The bug was in two places:
In both cases, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a failing unit test that reproduces #2598:
charmcraft remote-buildcrashes withAttributeError: 'ProjectService' object has no attribute 'name'.Bug
In
charmcraft/application/commands/remote.py, line 109:self._services.projectreturns theProjectServiceinstance (viaServiceFactory.__getattr__), not the actual project model. Thecastis a no-op at runtime, so callingproject.nameon aProjectServiceraisesAttributeError. The fix is to callself._services.project.get()instead.Reproducer
The test fails with:
Closes #2598