fix: use charmcraft pack instead of charmcraft pull in different-dir-metadata spread test#2672
Draft
fix: use charmcraft pack instead of charmcraft pull in different-dir-metadata spread test#2672
charmcraft pack instead of charmcraft pull in different-dir-metadata spread test#2672Conversation
…metadata spread test Agent-Logs-Url: https://github.com/canonical/charmcraft/sessions/1953ee4f-553a-4dc9-a7ed-3c1768c2d75a Co-authored-by: lengau <4305943+lengau@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
lengau
April 22, 2026 05:22
View session
|
Type checking with Command output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the broken spread test at https://github.com/canonical/charmcraft/actions/runs/24746125338/job/72401080632.
The
tests/spread/smoketests/different-dir-metadatatask was usingcharmcraft pullwhich doesn't exist as a command. Changed it tocharmcraft packto correctly test packing a charm with separate metadata files from a different directory.Changes
tests/spread/smoketests/different-dir-metadata/task.yaml: Replacecharmcraft pullwithcharmcraft pack