Conversation
9c1f662 to
7729ba6
Compare
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
medubelko
left a comment
There was a problem hiding this comment.
These are all small bits and bobs, but the gist is good!
Co-authored-by: Michael DuBelko <michael.dubelko@gmail.com> Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
|
Type checking with Command output |
Co-authored-by: Michael DuBelko <michael.dubelko@gmail.com> Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
|
Type checking with Command output |
1 similar comment
|
Type checking with Command output |
|
Type checking with Command output |
There was a problem hiding this comment.
The overall structure and content looks good to me! I suggested a few minor tweaks, but none of them are blocking.
Thanks, @lengau!
Co-authored-by: Michael DuBelko <michael.dubelko@canonical.com> Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
|
Type checking with Command output |
Co-authored-by: JJ Coldiron <jj.coldiron@canonical.com> Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
|
Type checking with Command output |
Co-authored-by: JJ Coldiron <jj.coldiron@canonical.com> Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: JJ Coldiron <jj.coldiron@canonical.com> Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
|
Type checking with Command output |
1 similar comment
|
Type checking with Command output |
Adds the migration guide drafted at https://docs.google.com/document/d/1HT3PHBNkKl2zc_gG_aUXY90F0IJHTf6B0hJnJRL_ppU/edit?tab=t.d1id7295jqbu#heading=h.wo85iddo4jkd
CHARMCRAFT-658
make lint && make test.