Replace azure_storage.py with object-storage-charmlib#220
Draft
theoctober19th wants to merge 2 commits into3.6/edgefrom
Draft
Replace azure_storage.py with object-storage-charmlib#220theoctober19th wants to merge 2 commits into3.6/edgefrom
theoctober19th wants to merge 2 commits into3.6/edgefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of issue or feature:
The charm currently uses the azure storage charm lib locally without it being served from a central place. Also, the charm was using a deprecated interface
azure, which is now deprecated in favor ofazure_storage.Solution:
Recently, we have consolidated the object storage charmlibs into a Python package, which makes it easier to track and maintain.
How was this change tested?
I noticed that we don't have integration tests for azure storage in this charm -- so I'd also like to discuss on how we can ensure the integration in a more automated and easier way.