[DPE-9515] chore: update etcd to 3.6.10#224
Open
Soundarya03 wants to merge 4 commits into3.6/edgefrom
Open
Conversation
Contributor
Mehdi-Bendriss
left a comment
Mehdi-Bendriss
left a comment
There was a problem hiding this comment.
Thanks Soundarya, left a couple of comments
Comment on lines
+9
to
+10
| CHARM_REVISIONS_TO_DEPLOY = {"x86_64": 159, "aarch64": 160} | ||
| WORKLOAD_VERSION = {"previous": "3.6.7", "target": "3.6.10"} |
Contributor
There was a problem hiding this comment.
i would rather we keep the source 3.6.5 and change the target instead
Contributor
There was a problem hiding this comment.
@Mehdi-Bendriss Why that? This test should ensure that users can upgrade from the previous etcd version to newer one. We have a separate test to ensure upgrading from the first stable release is possible, to.
In addition: If the test should update from 3.6.5, the charm revisions to be deployed in the line above also need to be adjusted again.
| [snap.revisions] | ||
| # amd64 | ||
| x86_64 = "27" | ||
| x86_64 = "32" |
Contributor
There was a problem hiding this comment.
are these the new snap revisions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of issue or feature:
Update snap revisions. Also update workload versions for tests.
Solution:
How was this change tested?