Skip to content

hooks: add script to remove unneeded apparmor profiles #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zyga wants to merge 1 commit into
base: core22
Choose a base branch
from
Open

hooks: add script to remove unneeded apparmor profiles #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions hook-tests/800-remove-unneeded-profiles.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
#!/bin/bash -e
set -x
APPARMOR_PROF_D="etc/apparmor.d"

declare -A allowed_profs

num_prof=0

for profile in "$APPARMOR_PROF_D"/*; do
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The glob pattern expansion could cause unexpected behavior if the directory is empty or doesn't exist. When the glob doesn't match any files, it will literally pass the string "etc/apparmor.d/*" to the loop. While the subsequent checks for directory and regular file will handle this gracefully, it's more robust to either check if the directory exists first, or use 'shopt -s nullglob' at the beginning of the script to make globs expand to nothing when they don't match.

Copilot uses AI. Check for mistakes.
# Skip if it is a directory
if [ -d "$profile" ]; then
continue
fi
# Skip if not a regular file
if [ ! -f "$profile" ]; then
continue
fi
num_prof=$((num_prof + 1))

filename=$(basename "$profile")
if ! [[ -v allowed_profs["$filename"] ]]; then
printf "Apparmor profile %s is not allowed\n" "$filename"
exit 1
fi
done

if [ "$num_prof" -ne "${#allowed_profs[@]}" ]; then
# If there were more we would have failed in the loop
printf "Less number of apparmor profiles than expected\n"
Comment on lines +22 to +29
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proper capitalization of the project name is "AppArmor" with two capital A's, not "apparmor". This should be corrected for consistency.

Suggested change
printf "Apparmor profile %s is not allowed\n" "$filename"
exit 1
fi
done
if [ "$num_prof" -ne "${#allowed_profs[@]}" ]; then
# If there were more we would have failed in the loop
printf "Less number of apparmor profiles than expected\n"
printf "AppArmor profile %s is not allowed\n" "$filename"
exit 1
fi
done
if [ "$num_prof" -ne "${#allowed_profs[@]}" ]; then
# If there were more we would have failed in the loop
printf "Less number of AppArmor profiles than expected\n"

Copilot uses AI. Check for mistakes.
Comment on lines +22 to +29
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proper capitalization of the project name is "AppArmor" with two capital A's, not "Apparmor". This should be corrected for consistency with the hook script (line 17 of hooks/800-remove-unneeded-profiles.chroot) and standard naming conventions.

Suggested change
printf "Apparmor profile %s is not allowed\n" "$filename"
exit 1
fi
done
if [ "$num_prof" -ne "${#allowed_profs[@]}" ]; then
# If there were more we would have failed in the loop
printf "Less number of apparmor profiles than expected\n"
printf "AppArmor profile %s is not allowed\n" "$filename"
exit 1
fi
done
if [ "$num_prof" -ne "${#allowed_profs[@]}" ]; then
# If there were more we would have failed in the loop
printf "Less number of AppArmor profiles than expected\n"

Copilot uses AI. Check for mistakes.
exit 1
fi
54 changes: 54 additions & 0 deletions hooks/800-remove-unneeded-profiles.chroot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
#!/bin/bash -ex

# Check profiles in /etc/apparmor.d/ and removes them if no matching binary
# exists.

APPARMOR_PROF_D="/etc/apparmor.d"

# The list of directories to check for binaries
SEARCH_DIRS=(
"/usr/bin"
"/usr/sbin"
"/usr/lib/systemd"
"/usr/lib/snapd"
"/usr/lib/cargo/bin"
)

echo "Starting AppArmor profile cleanup..."

# Iterate through files in /etc/apparmor.d/
for profile in "$APPARMOR_PROF_D"/*; do
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The glob pattern expansion could cause unexpected behavior if the directory is empty or doesn't exist. When the glob doesn't match any files, it will literally pass the string "/etc/apparmor.d/*" to the loop. While the subsequent checks for directory and regular file will handle this gracefully, it's more robust to either check if the directory exists first, or use 'shopt -s nullglob' at the beginning of the script to make globs expand to nothing when they don't match.

Copilot uses AI. Check for mistakes.
# Skip if it is a directory
if [ -d "$profile" ]; then
continue
fi
# Skip if not a regular file
if [ ! -f "$profile" ]; then
continue
fi

filename=$(basename "$profile")

# unix-chkpwd profile is actually for unix_chkpwd, fix this naming issue here
if [ "$filename" = unix-chkpwd ]
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string comparison should have the right-hand side quoted for consistency and safety. While it works in this case, the pattern should be if [ "$filename" = "unix-chkpwd" ] to follow best practices and prevent potential issues with special characters or word splitting.

Suggested change
if [ "$filename" = unix-chkpwd ]
if [ "$filename" = "unix-chkpwd" ]

Copilot uses AI. Check for mistakes.
then filename=unix_chkpwd
Comment on lines +33 to +34
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The if-then statement formatting is inconsistent with bash best practices. The condition and 'then' keyword should either be on the same line separated by a semicolon, or the 'then' should be on its own line. The current format with 'then' on the next line without proper indentation is unconventional.

Suggested change
if [ "$filename" = unix-chkpwd ]
then filename=unix_chkpwd
if [ "$filename" = unix-chkpwd ]; then
filename=unix_chkpwd

Copilot uses AI. Check for mistakes.
fi

match_found=false
for target_dir in "${SEARCH_DIRS[@]}"; do
# Check if the file exists in the target directory
if [ -e "${target_dir}/${filename}" ]; then
match_found=true
break
fi
done

# If no match was found in any directory, perform deletion
if [ "$match_found" = false ]; then
echo "[DELETING] $profile"
rm "$profile"
fi

done

echo "Cleanup complete."
Loading