feat: mknod intercepts now configurable from LXDProvider #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
lengau
approved these changes
Jan 16, 2025
lengau
approved these changes
Jan 16, 2025
Collaborator
lengau
left a comment
lengau
left a comment
There was a problem hiding this comment.
Needs a changelog item :-)
mattculler
force-pushed
the
work/CRAFT-2568-settable-mknod-intercept
branch
from
2da89ca to
65e8706
Compare
mr-cal
approved these changes
Jan 16, 2025
tigarmo
pushed a commit
that referenced
this pull request
Feb 3, 2025
…ks in Rockcraft. (#721) * ci: install lxd on ubuntu 24.04 Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> * ci: install lxd from the candidate channel Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> * docs: remove starter pack submodule (#713) Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> * fix: use Multipass-compatible instance names (#712) Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> * feat: upstream snap hooks (#710) * feat: add hookutil from downstream repo Lightly modified to remove proprietary identifiers, not functional in this state. * feat: make hookutil work generically * chore: disable lint check - may change approach later * feat: add unit tests from downstream * chore: linter issues * fix: craft-providers CI doesn't have lxd, mock it out * chore(style): rename per code review * chore(style): rename per code review * chore(style): rename per code review * chore: update changed names in test * refactor: remove globals, let LXDInstances keep project_name * chore: autoformat * fix: compat tag structure had been dependent on craft-application - This way is also simpler in the code, with a slight performance hit for the regex. - There's no way to get the full compat tag without having a fully-instantiated application. - Also fixed some debug output. * feat(tests): add configure hook integration test * feat: added remove hook test and beefed up configure hook test * chore: autoformat * fix: unit tests for changed interface * chore: autoformat, this time with the other tool! * chore: autoformat the third * fix: use the superior is-installed check from c-prov proper * fix: lint * feat: mknod intercepts now configurable from LXDProvider (#717) * feat: mknod intercepts now configurable from LXDProvider * fix: unit test * fix: lint * docs: update changelog (also includes item from #710) * feat: add modify_file method to Executor class * feat: add properties for getting setting pro services applied to environment * feat: make pull optional in Executor.modify_file * fix(LXDInstance): missing pro_services file returns none * trigger ci * refactor: adjustments to satisfy linters --------- Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> Co-authored-by: Callahan Kovacs <callahan.kovacs@canonical.com> Co-authored-by: Matt Culler <matt.culler@canonical.com>
clay-lake
added a commit
to clay-lake/craft-providers
that referenced
this pull request
Aug 27, 2025
…ks in Rockcraft. (canonical#721) * ci: install lxd on ubuntu 24.04 Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> * ci: install lxd from the candidate channel Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> * docs: remove starter pack submodule (canonical#713) Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> * fix: use Multipass-compatible instance names (canonical#712) Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> * feat: upstream snap hooks (canonical#710) * feat: add hookutil from downstream repo Lightly modified to remove proprietary identifiers, not functional in this state. * feat: make hookutil work generically * chore: disable lint check - may change approach later * feat: add unit tests from downstream * chore: linter issues * fix: craft-providers CI doesn't have lxd, mock it out * chore(style): rename per code review * chore(style): rename per code review * chore(style): rename per code review * chore: update changed names in test * refactor: remove globals, let LXDInstances keep project_name * chore: autoformat * fix: compat tag structure had been dependent on craft-application - This way is also simpler in the code, with a slight performance hit for the regex. - There's no way to get the full compat tag without having a fully-instantiated application. - Also fixed some debug output. * feat(tests): add configure hook integration test * feat: added remove hook test and beefed up configure hook test * chore: autoformat * fix: unit tests for changed interface * chore: autoformat, this time with the other tool! * chore: autoformat the third * fix: use the superior is-installed check from c-prov proper * fix: lint * feat: mknod intercepts now configurable from LXDProvider (canonical#717) * feat: mknod intercepts now configurable from LXDProvider * fix: unit test * fix: lint * docs: update changelog (also includes item from canonical#710) * feat: add modify_file method to Executor class * feat: add properties for getting setting pro services applied to environment * feat: make pull optional in Executor.modify_file * fix(LXDInstance): missing pro_services file returns none * trigger ci * refactor: adjustments to satisfy linters --------- Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> Co-authored-by: Callahan Kovacs <callahan.kovacs@canonical.com> Co-authored-by: Matt Culler <matt.culler@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox?Allow
craft-application'sProviderServiceto dis/allow interceptingmknodcalls in LXD.canonical/craft-application#607