Skip to content

ci: update cla check #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lengau merged 2 commits into from
Jul 18, 2025
Merged

ci: update cla check #778

lengau merged 2 commits into from
Jul 18, 2025

Conversation

@mr-cal
Copy link
Contributor

@mr-cal mr-cal commented Jul 17, 2025 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint && make test?

A longer term fix is to use full policy checker from starflow, but this is a quick fix that should unblock #777.

@mr-cal
ci: update cla check
beb9f55 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal marked this pull request as ready for review July 17, 2025 16:26
@mr-cal mr-cal requested a review from cmatsuoka as a code owner July 17, 2025 16:26
@mr-cal mr-cal requested review from a team and removed request for cmatsuoka July 17, 2025 16:26
@mr-cal
Copy link
Contributor Author

mr-cal commented Jul 17, 2025

Will need an admin to change required workflows.

@bepri bepri requested a review from a team July 17, 2025 20:22
upils
upils reviewed Jul 18, 2025
View reviewed changes
Copy link
Contributor

@upils upils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CLA check from starflow is already executed and marked as required, see https://github.com/canonical/craft-providers/actions/runs/16350565463/workflow?pr=778. What about deleting .github/workflows/cla-check.yaml then?

@mr-cal
Copy link
Contributor Author

mr-cal commented Jul 18, 2025

The CLA check from starflow is already executed and marked as required, see https://github.com/canonical/craft-providers/actions/runs/16350565463/workflow?pr=778. What about deleting .github/workflows/cla-check.yaml then?

Oh, interesting. Looks like this is running org-wide, not from starflow via .github/workflows/policy.yaml.

Looking at other repos with policy.yaml, the CLA check is running twice (example).

@mr-cal
ci: drop extra cla check
4a555df 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
Copy link
Contributor Author

mr-cal commented Jul 18, 2025

Upstream fix: canonical/starflow#64

@lengau lengau merged commit 5ba05e8 into main Jul 18, 2025
17 checks passed
@lengau lengau deleted the work/cla-check branch July 18, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lengau lengau lengau approved these changes

@bepri bepri bepri approved these changes

+1 more reviewer

@upils upils upils approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mr-cal @lengau @upils @bepri