WD-33240/full-site-view#315
Open
Onibenjo wants to merge 18 commits intofeature-task-managementfrom
Open
Conversation
- Rename selectedProject to activeProject in IViewsStore to avoid naming collision with IStore.selectedProject (different type) - Fix regex bug in selectTableView test helper - Move headers to module-level constant - Remove unnecessary gap: 0 in SCSS
URL cells wrap at any character so long URLs remain fully readable. Title cells truncate to a single line with ellipsis; a native hover tooltip exposes the full text. Also tightens the sidebar: zero horizontal padding on the drawer, alt background, and a highlighted background for the active project.
- Add FullSiteView.test.tsx with smoke test and mocks for panels/modals - Include pre-staged table header, status dot, and pagination tweaks
Connects row-level contextual menu to Copy update, Page refresh, and Remove page actions; renders singleton panels/modal outside the row loop.
MainTable.Header accepts className; classNames was being forwarded to the <th> DOM element, leaving the Actions column header un-centered and logging a React prop warning on every render.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
QA
QA steps
Fixes
Screenshots
It could be helpful to provide some screenshots to aid in QAing the change.