Open
Conversation
juditnovak
approved these changes
Jul 31, 2024
Contributor
juditnovak
left a comment
juditnovak
left a comment
There was a problem hiding this comment.
Thank you very much for the fix/enhancement :-)
welpaolo
reviewed
Aug 14, 2024
Contributor
welpaolo
left a comment
welpaolo
left a comment
There was a problem hiding this comment.
Looks good to me! Please update LIBPATCH version to avoid publishing issues
gboutry
force-pushed
the
fix/wrapper-context
branch
from
cdf3a15 to
e6844cc
Compare
Author
|
Force push is rebase on main + incrementing libpatch |
Contributor
* Update the wrapper methods context to the wrapped method. * Increase libpatch Signed-off-by: Guillaume Boutry <guillaume.boutry@canonical.com>
gboutry
force-pushed
the
fix/wrapper-context
branch
from
e6844cc to
1accd1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the wrapper methods context to the wrapped method.
Fix #186
This will make it easier to follow traced method in tracing tools (or even logs, if print method name in them)