fix(gh-actions/go/generate): Remove unnecessary token perms check#111
Open
fix(gh-actions/go/generate): Remove unnecessary token perms check#111
Conversation
We introduced this check in #69 because we passed the GITHUB_TOKEN to the third-party arduino/setup-protoc action. We're not using that action anymore since 9f12ec0 and instead download protoc directly from the GitHub releases. We still use the GITHUB_TOKEN to avoid rate limiting, but it's only used in a curl call to api.github.com. That is a trusted site, so there's no point in checking the token permissions.
Contributor
Author
|
I'm unsure if we should remove the now unused |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduced this check in #69 because we passed the
GITHUB_TOKENto the third-party arduino/setup-protoc action.We're not using that action anymore since 9f12ec0 and instead download protoc directly from the GitHub releases. We still use the
GITHUB_TOKENto avoid rate limiting, but it's only used in a curl call toapi.github.com. That is a trusted site, so there's no point in checking the token permissions.