Conversation
It could have been set at more global level, but it's not relevant yet.
It's the shellcheck suggested way to find out whether a command is there, and just nicer to use as it doesn't imply launching anything else.
bf900b6 to
9175586
Compare
I feel it would be better and more maintainable to add some example jobs to this repo to test the actions on each MR, so I'd rather prefer doing that once I've time for. |
|
I’m not going to merge something that is impacting a lot of project without having a link though :p Even if the changes looks trivial, as the previous PR failure, I don’t think we should trust not spotting any typos. |
Indeed, I agree with that, reason why I think we should first focus on having example projects to test against at each PR as I did on #28 before merging anything anywhere :) |
Cleanup the code and expose variables when required, as discussed in #25