CI: retry Docker Hub pulls + pin tags in smoke-test refresh step#369
Open
danielnovais-tech wants to merge 2 commits intocanonical:mainfrom
Open
CI: retry Docker Hub pulls + pin tags in smoke-test refresh step#369danielnovais-tech wants to merge 2 commits intocanonical:mainfrom
danielnovais-tech wants to merge 2 commits intocanonical:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the smoke-test GitHub Actions workflow to reduce CI flakiness from transient Docker Hub errors and to make the “refresh” portion of the smoke test more deterministic by avoiding :latest.
Changes:
- Added an exponential-backoff
pull_with_retryhelper for Docker image pulls. - Updated the set of smoke-test containers to use specific tags instead of implicit
:latest.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+126
to
+128
| echo "Pull failed (attempt $attempt/$max_attempts) for $image, retrying in ${wait_time}s..." | ||
| sleep "$wait_time" | ||
| wait_time=$((wait_time * 2)) |
Comment on lines
+135
to
+152
| # Run containers with pinned tags (avoid :latest drift) | ||
| pull_with_retry redis:7 | ||
| sudo docker run --restart=always -d redis:7 | ||
|
|
||
| pull_with_retry rabbitmq:3.13 | ||
| sudo docker run --restart=always -d rabbitmq:3.13 | ||
|
|
||
| pull_with_retry grafana/grafana:11 | ||
| sudo docker run --restart=always -d grafana/grafana:11 | ||
|
|
||
| pull_with_retry jenkins/jenkins:2.462 | ||
| sudo docker run --restart=always -d jenkins/jenkins:2.462 | ||
|
|
||
| pull_with_retry nginx:1.27 | ||
| sudo docker run --restart=always -d nginx:1.27 | ||
|
|
||
| pull_with_retry postgres:17 | ||
| sudo docker run --restart=always -d -e POSTGRES_HOST_AUTH_METHOD=trust postgres:17 |
Author
|
@copilot apply changes based on the comments in this thread |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.