Merged
Conversation
sefeijoo
force-pushed
the
sefeijoo/update-rule-019
branch
from
3a51564 to
737fedc
Compare
sefeijoo
force-pushed
the
sefeijoo/update-rule-019
branch
from
737fedc to
3a777a5
Compare
SecondSkoll
requested changes
Apr 13, 2026
Contributor
SecondSkoll
left a comment
SecondSkoll
left a comment
There was a problem hiding this comment.
A couple of comments - but good work so far.
An additional issue is that tests are failing. This is because your implementation only captures the existence of the assets.ubuntu part of the URL (e.g. :::{figure} https://assets.ubuntu.com/v1/abc123 is captured as :::{figure} https://assets.ubuntu.
You could change this - but it would be better to change to modify the existing tokens - which should capture the whole URL (as it does for Drive based images).
Co-authored-by: Michael Park <michael.park@canonical.com>
Co-authored-by: Michael Park <michael.park@canonical.com>
…entation-style-guide into sefeijoo/update-rule-019
SecondSkoll
approved these changes
Apr 14, 2026
Contributor
SecondSkoll
left a comment
SecondSkoll
left a comment
There was a problem hiding this comment.
Looks great, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #143