Skip to content

chore(kill-mode): remove kill-mode process #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanksyoon merged 11 commits into from
Apr 24, 2026
Merged

chore(kill-mode): remove kill-mode process #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cd5d5ef
remove kill-mode process
yanksyoon Apr 8, 2026
a704ff1
chore: update version to 0.18.1 and document removal of KillMode=process
yanksyoon Apr 10, 2026
8deb6ad
chore: add cgroup and systemd to vale vocabulary
Copilot Apr 10, 2026
6537627
Merge branch 'main' into chore/remove-killmode
yanksyoon Apr 13, 2026
ce524a8
debug
yanksyoon Apr 14, 2026
8435b9a
chore: ignore macOS artifacts
yanksyoon Apr 14, 2026
23a48fe
Merge branch 'main' into chore/remove-killmode
yanksyoon Apr 16, 2026
d2201c2
ci: remove debug
yanksyoon Apr 16, 2026
44f2c97
Merge branch 'main' into chore/remove-killmode
yanksyoon Apr 21, 2026
f5dff27
Merge branch 'main' into chore/remove-killmode
yanksyoon Apr 21, 2026
15e44e0
Merge branch 'main' into chore/remove-killmode
yanksyoon Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ venv/
.mypy_cache
*.egg-info/

# OS artifacts
.DS_Store

# BEGIN VALE WORKFLOW IGNORE
.vale/styles/*
!.vale/styles/local
Expand Down
2 changes: 2 additions & 0 deletions .vale/styles/config/vocabularies/local/accept.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ aproxy
Aproxy
GitHub App
backoff
cgroup
denylist
enqueued
Gunicorn
Expand All @@ -15,6 +16,7 @@ plaintext
proxied
reactively
rollout
systemd
Tmate
unregisters
untrusted
Expand Down
4 changes: 4 additions & 0 deletions docs/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

This changelog documents user-relevant changes to the GitHub runner charm.

## 2026-04-22

- Removed `KillMode=process` from the runner manager systemd service, restoring the default `control-group` kill mode. This ensures all child processes in the service's cgroup are properly terminated when the service stops, preventing orphaned runner processes.
Comment thread
yanksyoon marked this conversation as resolved.

## 2026-04-17

- Added `token-secret-id` and `openstack-clouds-yaml-secret-id` configuration options, allowing the GitHub token and OpenStack `clouds.yaml` to be supplied through Juju user secrets. When set, these take precedence over the plaintext `token` and `openstack-clouds-yaml` options, which remain supported as a compatibility fallback.
Expand Down
2 changes: 1 addition & 1 deletion github-runner-manager/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

[project]
name = "github-runner-manager"
version = "0.18.0"
version = "0.18.1"
authors = [
{ name = "Canonical IS DevOps", email = "is-devops-team@canonical.com" },
]
Expand Down
1 change: 0 additions & 1 deletion src/manager_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,6 @@ def _setup_service_file(unit_name: str, config_file: Path, log_file: Path, log_l
RestartSec=30
RestartSteps=5
RestartMaxDelaySec=600
KillMode=process
StandardOutput=append:{log_file}
StandardError=append:{log_file}

Expand Down
Loading