Open
Conversation
marco6
force-pushed
the
deprecate-single-thread
branch
from
ad232e9 to
96de8cc
Compare
marco6
force-pushed
the
deprecate-single-thread
branch
from
96de8cc to
1d2b1ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes single-threaded configuration as dqlite is now multithreaded.
On older versions, it shouldn't really matter as I highly doubt anyone will ever be able to measure the impact of taking and releasing an uncontended lock, constantly taken on the same thread.