Add isolation level support check#422
Open
larrasket wants to merge 1 commit intocanonical:v3from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
database/sql/driver.ConnBeginTxinterface requires drivers to validate transaction options and return errors for unsupported configurations.currently, BeginTx would silently accept any isolation level or read-only setting and just run BEGIN, which might be misleading.
the implementation returns
ErrIsolationLevelNotSupportedfor anything other thanLevelDefaultorLevelSerializable(since SQLite/dqlite only supports serializable), and returnsErrReadOnlyNotSupportedfor read-only transactions (not supported by dqlite). Both error types are exported so callers can check what went wrong witherror.As.Closes #266