Skip to content

Disable jubilant logging for juju.deploy, juju.config and juju.exec#84

Closed
seb4stien wants to merge 1 commit intomainfrom
disable-jubilant-logging
Closed

Disable jubilant logging for juju.deploy, juju.config and juju.exec#84
seb4stien wants to merge 1 commit intomainfrom
disable-jubilant-logging

Conversation

@seb4stien
Copy link
Copy Markdown
Collaborator

Add log=False to all juju.deploy(), juju.config() and juju.exec() calls in integration tests.

Add log=False to all juju.deploy(), juju.config() and juju.exec() calls
in integration tests to disable jubilant logging for security reasons.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

Test results for commit d123817

Lint checks failed for d123817

```

tests/integration/test_charm.py:26: error: No overload variant of "config" of "Juju" matches argument types "str", "dict[str, str]", "bool" [call-overload]
tests/integration/test_charm.py:26: note: Possible overload variants:
tests/integration/test_charm.py:26: note: def config(self, app: str, *, app_config: bool = ...) -> Mapping[str, bool | int | float | str | SecretURI]
tests/integration/test_charm.py:26: note: def config(self, app: str, values: Mapping[str, bool | int | float | str | SecretURI], *, reset: str | Iterable[str] = ...) -> None
tests/integration/test_charm.py:26: note: def config(self, app: str, *, reset: str | Iterable[str]) -> None
tests/integration/test_charm.py:48: error: No overload variant of "config" of "Juju" matches argument types "str", "dict[str, str]", "bool" [call-overload]
tests/integration/test_charm.py:48: note: Possible overload variants:
tests/integration/test_charm.py:48: note: def config(self, app: str, *, app_config: bool = ...) -> Mapping[str, bool | int | float | str | SecretURI]
tests/integration/test_charm.py:48: note: def config(self, app: str, values: Mapping[str, bool | int | float | str | SecretURI], *, reset: str | Iterable[str] = ...) -> None
tests/integration/test_charm.py:48: note: def config(self, app: str, *, reset: str | Iterable[str]) -> None
tests/integration/conftest.py:70: error: Unexpected keyword argument "log" for "deploy" of "Juju" [call-arg]
tests/integration/conftest.py:70: note: "deploy" defined in "jubilant._juju"
tests/integration/conftest.py:87: error: Unexpected keyword argument "log" for "deploy" of "Juju" [call-arg]
tests/integration/conftest.py:87: note: "deploy" defined in "jubilant._juju"
tests/integration/conftest.py:115: error: Unexpected keyword argument "log" for "deploy" of "Juju" [call-arg]
tests/integration/conftest.py:115: note: "deploy" defined in "jubilant._juju"
Found 5 errors in 2 files (checked 10 source files)

@github-actions
Copy link
Copy Markdown
Contributor

Test results for commit d123817

Test coverage for d123817

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py      54      9      2      1    82%   72-78, 99-101, 114-116
src/state.py      85      1     16      1    98%   204
----------------------------------------------------------
TOTAL            139     10     18      2    92%

Static code analysis report

Run started:2026-04-16 11:29:17.192542+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 975
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions
Copy link
Copy Markdown
Contributor

Test results for commit d123817

Test coverage for d123817

Name            Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------
src/charm.py      140     31     36     14    73%   103-106, 111-112, 116, 123-125, 130->136, 135, 138, 149-150, 152, 154->160, 159, 165-166, 173-176, 209-210, 231, 237, 240, 255-278
src/policy.py      98     68     20      0    25%   24-26, 31, 40-44, 55, 72-76, 89-103, 133-134, 142, 175-196, 219-238, 249-257, 265-271, 279-284, 295-298
src/relay.py      142      8     46      2    95%   155->178, 252-268, 398-401
src/timer.py       11      4      0      0    64%   48-61
-----------------------------------------------------------
TOTAL             391    111    102     16    70%

Static code analysis report

Run started:2026-04-16 11:29:33.210764+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1810
  Total lines skipped (#nosec): 6
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 1

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions
Copy link
Copy Markdown
Contributor

Test results for commit d123817

Test coverage for d123817

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py     176     36     38      8    78%   67-69, 76-77, 81, 94, 97-98, 128, 170-200, 213->228, 221-227, 353-367
src/squid.py     110      6     34      5    92%   65, 75, 175, 264, 313, 322, 344->351, 346->348
----------------------------------------------------------
TOTAL            286     42     72     13    84%

Static code analysis report

Run started:2026-04-16 11:29:37.150496+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2243
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 1

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@seb4stien seb4stien closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant