feat(Lifecycle)!: use craft-application's new plugin groups#326
Open
feat(Lifecycle)!: use craft-application's new plugin groups#326
Conversation
Breaking change: We're extending the MINIMAL plugin group rather than the DEFAULT plugin group so that we can pick upstream plugins as needed, ensuring they work with imagecraft.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Imagecraft’s lifecycle/plugin integration to use craft-application’s new “plugin groups” mechanism, switching the baseline group to MINIMAL so upstream plugins can be selected more explicitly for Imagecraft compatibility.
Changes:
- Add
ImagecraftLifecycleService.get_plugin_group()to returnPluginGroup.MINIMALplus Imagecraft-specific plugins. - Remove
Imagecraft._get_app_plugins()override from the main Application class (plugin selection now handled via lifecycle plugin groups).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
imagecraft/services/lifecycle.py |
Introduces get_plugin_group() to merge MINIMAL group plugins with Imagecraft’s custom plugins. |
imagecraft/application.py |
Removes the legacy app plugin hook that’s superseded by the new plugin-group mechanism. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tigarmo
approved these changes
Apr 24, 2026
mr-cal
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change: We're extending the MINIMAL plugin group rather than the DEFAULT plugin group so that we can pick upstream plugins as needed, ensuring they work with imagecraft.
Fixes #314
IMAGECRAFT-121
make lint && make test.