Skip to content

feat(Project): add MBR and hybrid volume schemas #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lengau merged 13 commits into from
Apr 27, 2026
Merged

feat(Project): add MBR and hybrid volume schemas #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f39ccc8
feat(Project): Add the ability to accept MBR volumes
lengau Apr 21, 2026
a9b9023
test: add volume tests
lengau Apr 21, 2026
c7b12a6
feat(volumes): add a HybridVolume schema ("mbr,gpt")
lengau Apr 21, 2026
009248e
test: add a gpt-unsupported-fields test case for invalid projects
lengau Apr 21, 2026
7b6e51c
test: add tests for get_partition_name
lengau Apr 21, 2026
4037d33
Merge branch 'main' into work/volume-structure
lengau Apr 21, 2026
b7371ed
fix: tests
lengau Apr 23, 2026
04ce271
chore: Merge remote-tracking branch 'origin/main' into work/volume-st…
lengau Apr 23, 2026
458745c
fix: unit tests
lengau Apr 23, 2026
9688690
fix: docs
lengau Apr 23, 2026
63c0336
fix: requires-root integration tests
lengau Apr 23, 2026
9afbe44
Update imagecraft/models/volume.py
lengau Apr 23, 2026
a3e9e39
Merge branch 'main' into work/volume-structure
lengau Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions docs/reference/imagecraft-yaml.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@ partitions.
.. kitbash-field:: Project volumes
:override-type: dict[str, Volume]

.. kitbash-field:: Volume volume_schema
.. kitbash-field:: GPTVolume volume_schema
:prepend-name: volumes.<volume-name>

.. kitbash-field:: Volume structure
.. kitbash-field:: GPTVolume structure
:prepend-name: volumes.<volume-name>
Comment thread
lengau marked this conversation as resolved.
:override-type: list[Partition]

Expand All @@ -88,28 +88,28 @@ Partition keys
The following keys can be declared for each partition listed in the volume's
``structure`` key.

.. kitbash-field:: StructureItem name
.. kitbash-field:: GPTStructureItem name
:prepend-name: volumes.<volume-name>.structure.<partition>

.. kitbash-field:: StructureItem id
.. kitbash-field:: GPTStructureItem id
:prepend-name: volumes.<volume-name>.structure.<partition>

.. kitbash-field:: StructureItem role
.. kitbash-field:: GPTStructureItem role
:prepend-name: volumes.<volume-name>.structure.<partition>

.. kitbash-field:: StructureItem structure_type
.. kitbash-field:: GPTStructureItem structure_type
:prepend-name: volumes.<volume-name>.structure.<partition>

.. kitbash-field:: StructureItem size
.. kitbash-field:: GPTStructureItem size
:prepend-name: volumes.<volume-name>.structure.<partition>

.. kitbash-field:: StructureItem filesystem
.. kitbash-field:: GPTStructureItem filesystem
:prepend-name: volumes.<volume-name>.structure.<partition>

.. kitbash-field:: StructureItem filesystem_label
.. kitbash-field:: GPTStructureItem filesystem_label
:prepend-name: volumes.<volume-name>.structure.<partition>

.. kitbash-field:: StructureItem partition_number
.. kitbash-field:: GPTStructureItem partition_number
:prepend-name: volumes.<volume-name>.structure.<partition>


Expand Down
12 changes: 10 additions & 2 deletions imagecraft/models/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,25 @@
get_partition_name,
)

from imagecraft.models.volume import FileSystem, Volume, Role, StructureItem
from imagecraft.models.volume import (
FileSystem,
BaseVolume,
GPTVolume,
Volume,
Role,
GPTStructureItem,
)
from imagecraft.models.grammar import get_grammar_aware_volume_keywords

__all__ = [
"FileSystem",
"Project",
"Platform",
"GPTVolume",
"Volume",
"VolumeFilesystemsModel",
"Role",
"StructureItem",
"GPTStructureItem",
"get_partition_name",
"get_grammar_aware_volume_keywords",
]
Loading
Loading