-
Notifications
You must be signed in to change notification settings - Fork 24
Update snap config docs to match new key names & improve consistency #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
st3v3nmw
wants to merge
3
commits into
canonical:main
Choose a base branch
from
st3v3nmw:consistent-urls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,13 +59,14 @@ Replacing the placeholder variables with their appropriate values. | |
|
|
||
| When the configuration is complete, you’ll receive confirmation that the client was registered successfully or if an error occurred. | ||
|
|
||
| **Method #3: Use `set` to set individual configuration values** | ||
| **Method #3: Use `snap set` to set individual configuration values** | ||
|
|
||
| You can use the snap `set` command to set individual configuration values. For example: | ||
| You can use the `snap set` command to set individual configuration values. For example: | ||
|
|
||
| ```bash | ||
| snap set landscape-client computer-title {LANDSCAPE_COMPUTER_TITLE} | ||
| snap set landscape-client url {LANDSCAPE_URL} | ||
| snap set landscape-client url https://{LANDSCAPE_FQDN}/message-system | ||
| snap set landscape-client ping-url http://{LANDSCAPE_FQDN}/ping | ||
| ``` | ||
|
|
||
| After setting any configuration variables using `set`, you’ll need to restart the client snap for the new configuration to be applied: | ||
|
|
@@ -78,14 +79,23 @@ The options you can set with snap `set` are: | |
|
|
||
| - `account-name` | ||
| - `computer-title` | ||
| - `landscape-url` | ||
| - `url` | ||
| - `ping-url` | ||
|
Comment on lines
+82
to
+83
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar concerns apply to this how-to guide.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can hold the documentation changes back until the code changes land in |
||
| - `log-level` | ||
| - `script-users` | ||
| - `manager-plugins` | ||
| - `monitor-plugins` | ||
| - `access-group` | ||
| - `registration-key` | ||
|
|
||
| ```{note} | ||
| When you run `snap set`, the value is written to snap options and then applied to `landscape-client.conf` by the `configure` hook. Only the keys listed above are recognized and applied. If you set an unrecognized key, it will not be written to the configuration file but will persist in snap options, which can be misleading. Use `snap unset landscape-client <key>` to remove it. | ||
| ``` | ||
|
|
||
| ```{note} | ||
| The keys `landscape-url` and `landscape-ping-url` are deprecated aliases for `url` and `ping-url`. They still work but will be removed in a future release. Use `url` and `ping-url` for new configurations. | ||
| ``` | ||
|
|
||
| ### Accept the registration | ||
|
|
||
| ```{note} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these changes, the guide would only apply to the snap on the edge channel (once those changes are merged). But earlier in the guide we say to use the
latest/stablechannel. We should either hold off on this change until the changes to the snap land inlatest/stable, or else make a note in this guide about the differences in those scenarios.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can hold the documentation changes back until the code changes land in
latest/stable.