doc: set GOTOOLCHAIN=auto for RTD Go builds#1208
Merged
roosterfish merged 1 commit intocanonical:mainfrom Feb 3, 2026
Merged
Conversation
ec7f90d to
4844ce4
Compare
Update .readthedocs.yaml to set GOTOOLCHAIN=auto when building the lxd integration and make doc-html-rtd. This fixes RTD build issues by allowing Go to auto-fetch the required Go patch version when the local toolchain is outdated. Signed-off-by: Minae Lee <minae.lee@canonical.com>
4844ce4 to
7d87d30
Compare
Contributor
Author
|
Linkcheck is failing due to issues that are fixed in #1206. This PR otherwise behaves as expected - the correct version of Go is fetched during the RTD build and the RTD build succeeds. |
roosterfish
approved these changes
Feb 3, 2026
| - git fetch --unshallow || true | ||
| - cd doc && make integrate | ||
| - cd doc/integration/lxd/ && go build -ldflags "-s -w" -o trimpath -o lxc.bin ./lxc | ||
| - cd doc && make GOTOOLCHAIN=auto integrate |
Contributor
There was a problem hiding this comment.
This means we still have to update the golang: "1.25" line above once we go to 1.26 if I understand correctly. But it ensures the right patch version is picked. LGTM.
roosterfish
added a commit
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
.readthedocs.yamlto setGOTOOLCHAIN=autowhen building the lxd integration andmake doc-html-rtd. This fixes RTD build issues by allowing Go to auto-fetch the required Go patch version when the local toolchain is outdated.