Cluster manager proof of concept for reverse tunnel [spike]#801
Draft
edlerd wants to merge 1 commit intocanonical:mainfrom
Draft
Cluster manager proof of concept for reverse tunnel [spike]#801edlerd wants to merge 1 commit intocanonical:mainfrom
edlerd wants to merge 1 commit intocanonical:mainfrom
Conversation
| } | ||
|
|
||
| tlsConfig := shared.InitTLSConfig() | ||
| tlsConfig.InsecureSkipVerify = true // todo For testing purposes, skip verification of the server's certificate |
Check failure
Code scanning / CodeQL
Disabled TLS certificate check High
| }, | ||
| } | ||
| httpClient.Transport = transport | ||
| httpResp, err := httpClient.Do(httpReq) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in network request Critical
b22ffde to
1d36035
Compare
Signed-off-by: David Edler <david.edler@canonical.com>
Contributor
|
@edlerd can this PR be closed? |
Contributor
Author
We might want to use this approach at a later time, so I'd keep it open in draft state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Draft because this only qualifies as a spike and is by no means complete