Restructure (7): Make extensions package public#607
Merged
roosterfish merged 6 commits intocanonical:v3from Feb 3, 2026
Merged
Restructure (7): Make extensions package public#607roosterfish merged 6 commits intocanonical:v3from
roosterfish merged 6 commits intocanonical:v3from
Conversation
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
tugbataluy
approved these changes
Feb 3, 2026
Contributor
tugbataluy
left a comment
tugbataluy
left a comment
There was a problem hiding this comment.
LGTM! 👍
The migration of the Extensions type from internal/ to the public microcluster/types package is clean and follows the same pattern established in the previous restructure PRs. As far as I understand from the previous PRs, this continues making internal types properly accessible to downstream consumers while enabling mocking for unit tests.
roosterfish
added a commit
that referenced
this pull request
Feb 4, 2026
Can only be merged after (won't build before): * #607 This is the eigth PR taken from a single commit in #534 (even though in this case the actual changes are very different from the original commit). The final package layout will be different but to allow reviewing the changes in smaller chunks I will split this PR by its commits. In this PR the DB interface is made public. It's returned by the public `State` interface and should therefore not be located inside the `internal/` package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the seventh PR taken from a single commit in #534 (even though in this case the actual changes are very different from the original commit).
The final package layout will be different but to allow reviewing the changes in smaller chunks I will split this PR by its commits.
In this PR the extensions package is made public so that the actual types can be accessed by importers of Microcluster.