Changes to get microovn working for PS9#85
Conversation
matperin
left a comment
matperin
left a comment
There was a problem hiding this comment.
Not the cleanest workaround but, as we discussed internally, there are no other non-intrusive solutions to the ovs-vsctl aliasing problem.
Other than the nitpick about adding a comment concerning this the changes seem good for what we want to achieve.
| subprocess.run(["modprobe", "openvswitch"]) | ||
| subprocess.run(["apt", "remove", "-y", *APT_OVS_PACKAGES]) | ||
| subprocess.run(["rm", "-f", "/usr/bin/ovs-vsctl"]) | ||
| subprocess.run(["apt", "remove", "-y", "--allow-change-held-packages", *APT_OVS_PACKAGES]) |
There was a problem hiding this comment.
nit: Since we are making quite a "dirty" workaround here and it is clear by our internal discussion why it is necessary, I think a little comment with a note on this decision could help troubleshooting in the future.
While it works in theory, I am a little concerned that this manual management of binaries could cause some troubles in some particular juju deployments, so having a reference for this could help pinpoint possible issues.
we cannot remove doca-openvswitch-switch as it is depended on, so we remove ovs-vsctl. openvswitch-switch is marked as held by maas so we need to force remove it. Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
2 participants
we cannot remove doca-openvswitch-switch as it is depended on, so we remove ovs-vsctl.
openvswitch-switch is marked as held by maas so we need to force remove it.