Conversation
crypticC0der
commented
Apr 14, 2026
crypticC0der
commented
- lspci is inaccessable by the snap outside of --dangerous, so we fix this
- we need a slight rework to the externalIDs logic when nothing else exists there.
crypticC0der
force-pushed
the
lspci
branch
2 times, most recently
from
6d5599f to
4a99ddf
Compare
Currently this check would report stable if the output was more thn just "--", such as two lines of "--". So instead we now check for non "--" lines, which is what we really should have been doing the whole time. Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
crypticC0der
force-pushed
the
lspci
branch
3 times, most recently
from
e274182 to
a228409
Compare
snapcraft latest/edge doesnt seem to be properly pulling in dependancies, which is a problem for us, so we need to use candidate for the time being. Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
There was a problem hiding this comment.
Maybe it would be better to split Minor dpu reworks. into two commits?
I know that they are very minor changes but I think they achieve different things and it is better to have separate commit messages for future reference.
Other than that the rest seems good. Do we know why snapcraft latest/edge is not pulling dependencies properly, though? This is probably something we should fix at the root, if we have the chance.
the version in latest edge (post104) only pulls in explicitly mentioned packages and not their dependancies, which is a pain and I am expecting this to be a bug that gets reverted before it hits stable, i have put a message in their channel asking about it. |
Fixes an issue where an unneeded comma is added when externalids is empty. Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
Adds the lspci binary for use outside of --devmode. Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
matperin
left a comment
matperin
left a comment
There was a problem hiding this comment.
Thanks for the change, looks good!
Use latest edge snapd when we are using an edge base. Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
matperin
left a comment
matperin
left a comment
There was a problem hiding this comment.
The added snap refresh for snapd inside the container seems a good addition, I will confirm my previous approval.
2 participants
