Skip to content

patch(DPE-9772): CI Green#317

Open
Gu1nness wants to merge 12 commits into8/edgefrom
DPE-9772-mongo-db-bug-fix-ci-stabilisation-green
Open

patch(DPE-9772): CI Green#317
Gu1nness wants to merge 12 commits into8/edgefrom
DPE-9772-mongo-db-bug-fix-ci-stabilisation-green

Conversation

@Gu1nness
Copy link
Copy Markdown
Contributor

@Gu1nness Gu1nness commented Apr 22, 2026

🏷️ Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling and CI
  • Dependencies upgrade or change
  • Chores / refactoring

📝 Description

  • Poetry dynamic versioning check: We broke releasing once by pushing an invalid pyproject.toml file, let's not reproduce that.
  • Race condition (exposed by release testing):
    • TLS + Mongos => we were not checking properly if TLS and Mongos had the same CA and if mongos had received certificates. Mongos would start without internal certificate, preventing from building the cluster.
    • We were potentially running some relation-changed events too early.
  • Other bugs
    • Generating the config server URI for the local mongos running along with config-server would fail if there are more than 1 mongos integrated. This is fixed by remodelling the way we build the URI, ensuring we don't unnecessarily access the mongos_cluster_relation relation object.

🧪 Manual testing steps

1. Deploy config server + 1 shard + mongos.
2. Integrate config-server and shard.
3. Integrate config-server to tls and shard to tls (at least peer-certs).
4. Integrate mongos to config server and tls integration to mongos at the same time.
5. This should end up quickly.

🔬 Automated testing steps

Added a test to Mongos LDAP suite (reverse scenario).
TLS race condition test should not be flaky anymore.
Updated UT.

✅ Checklist

  • My code follows the code style of this project.
  • I have added or updated any relevant documentation.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Gu1nness Gu1nness marked this pull request as ready for review April 24, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant