[MISC] Improve k8s canonical DNS lookup (backport)#158
Merged
astrojuanlu merged 1 commit into8.4/edgefrom Mar 17, 2026
Merged
Conversation
github-actions
Bot
added
the
Libraries: Out of sync
sinclert-canonical
approved these changes
Mar 17, 2026
Replace getfqdn-based k8s hostname resolution with a canonical-name lookup built on getaddrinfo(AI_CANONNAME). Handle resolver failures, keep the trailing dot returned by DNS, and update the Kubernetes unit tests for the charm, provider, upgrade, and utility helpers. Fixes #137 Signed-off-by: Guillaume Boutry <guillaume.boutry@canonical.com>
astrojuanlu
force-pushed
the
juanlu/backport-fqdn-resolution
branch
from
cab97ac to
b2e42be
Compare
Contributor
Author
|
No code changes (just a signoff) and all tests were passing before (!) so I'm merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Backports #138 to 8.4/edge
Solution
Checklist