Skip to content

[MISC] [VM] Raise error properly if initialization fails (8.4) #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astrojuanlu merged 1 commit into from
Apr 16, 2026
Merged

[MISC] [VM] Raise error properly if initialization fails (8.4) #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion machines/src/mysql_vm_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ def initialise_mysqld(self) -> None:

try:
self.reset_data_dir()
subprocess.run(bootstrap_command) # noqa: S603
subprocess.run(bootstrap_command, check=True) # noqa: S603
except subprocess.CalledProcessError:
logger.exception("Failed to initialise MySQL data directory")
raise MySQLInitialiseMySQLDError from None
Expand Down
15 changes: 9 additions & 6 deletions machines/tests/unit/test_mysqlsh_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,12 +481,15 @@ def test_initialise_mysqld(self, _subprocess_run, _reset_data_dir):
self.mysql.initialise_mysqld()

_reset_data_dir.assert_called_once()
_subprocess_run.assert_called_once_with([
"/usr/bin/sudo",
"/snap/bin/charmed-mysql.mysqld-initialize",
"--datadir",
"/var/snap/charmed-mysql/common/var/lib/mysql",
])
_subprocess_run.assert_called_once_with(
[
"/usr/bin/sudo",
"/snap/bin/charmed-mysql.mysqld-initialize",
"--datadir",
"/var/snap/charmed-mysql/common/var/lib/mysql",
],
check=True,
)

@patch("mysql_vm_helpers.MySQL.reset_data_dir")
@patch("subprocess.run")
Expand Down
Loading